Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load module if not Loaded #31

Closed
nusphere opened this issue Apr 8, 2022 · 1 comment
Closed

Load module if not Loaded #31

nusphere opened this issue Apr 8, 2022 · 1 comment

Comments

@nusphere
Copy link

nusphere commented Apr 8, 2022

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

So far it has been possible to reload corresponding module dependencies in a module via the init method. @see ModuleManagerInterface::loadModule

Unfortunately, this can lead to side effects if the desired dependency is already loaded and possibly preconfigured by a previous module.

The current behavior would reload and also initialize the dependency. As a result, any configurations in the dependency are now obsolete.

For this reason, I would like to see a new method in the interface that only loads the corresponding dependency if it is not already loaded (ModuleManagerInterface::loadModuleIfNotLoaded)

@nusphere
Copy link
Author

nusphere commented Apr 8, 2022

this issue is no longer necessary as it is more of a bug. the behavior described here should already be supported. @see #32

@nusphere nusphere closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant