2.4.x - Allow installation on PHP 8 #60
Conversation
There was a problem hiding this comment.
I've noted some problems with the Travis configuration.
However, I think the more important concern I have is: why would we expand the PHP versions supported on this particular release series?
The Laminas security window policy indicates that we only support (a) the current release branch, and (b) any release branch where the minimum supported PHP version is still supported by php.net.
The 2.4 series falls outside that realm. On top of that, if a user is on 7.3 or 7.4 currently, they can already upgrade to the 2.5 series; if they are on PHP 8, installation will give them 2.5+. Expanding what we support on the 2.4 series is unnecessary, as users of later versions of PHP can already get a later version.
| env: | ||
| - DEPS=latest | ||
| - CS_CHECK=true | ||
| - TEST_COVERAGE=true |
There was a problem hiding this comment.
We cannot drop versions from testing that are explicitly supported via the package constraints. You either need to bump the PHP constraint to ^7.2, or keep the above.
There was a problem hiding this comment.
PHPUnit 8.x doesn't support PHP 7.1 and PHPUnit 7.x doesn't support 8.x. What do you recommend in this case?
|
The main reason for supporting PHP 8 in this old minor version is because our system uses PHP 7.2 and we are migrating to 8.0. Since our app uses Otherwise we would need to migrate all our systems to something like PHP 7.4 first and then 8.0, which almost doubles the work required for the upgrade. |
Signed-off-by: Juan Basso <[email protected]>
|
To avoid changing the library and the minimum PHP tested version because of PHPUnit I will be closing it. Since the code itself is compatible with PHP 8 for the most part, we can specify the platform version in the composer while we are doing the transition. |
Description
Same as #46 for 2.4.x series. This will allow the library to be installed in wider ranger of PHP versions since 2.5 can't be installed in versions below 7.3.