Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar hidden will soon not be remembered because of cookie settings #44

Open
Koen1999 opened this issue Jan 30, 2022 · 0 comments
Open
Labels
Bug Something isn't working

Comments

@Koen1999
Copy link

Bug Report

Q A
Version(s) 2.4.0

Summary

Firefox warns about the laminas-hidden cookie. In specific, it references the following documentation: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite#samesitenone_requires_secure

The problem is that the cookie will be rejected by future browser versions.

Current behavior

laminas-hidden cookie is set with SameSite=None and without secure.

I believe the code responsible for this behaviour is located here: https://github.com/laminas/laminas-developer-tools/blob/2.4.x/view/laminas-developer-tools/toolbar/toolbar.js

How to reproduce

Enable the laminas-developer-tools toolbar. Visit your website. Observe the console output of your browser.

Expected behavior

No warnings should be thrown.

Since not all websites under development are served over a secure connection, I propose setting SameSite=Lax.

@Koen1999 Koen1999 added the Bug Something isn't working label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant