Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Whoops library when DeveloperTools module is enabled #30

Open
divix1988 opened this issue Mar 18, 2020 · 3 comments
Open

Broken Whoops library when DeveloperTools module is enabled #30

divix1988 opened this issue Mar 18, 2020 · 3 comments
Labels
Awaiting Author Updates Bug Something isn't working

Comments

@divix1988
Copy link

Summary

Can read text when exception is thrown and Whoops library is used. https://github.com/Ppito/laminas-whoops

Current behavior

image

How to reproduce

  • include laminas-developer-tools module
  • include laminas-whoops module
  • throw any random exception manually
  • check the Environment and details section

Expected behavior

The text should be readable regardless if Laminas contains DeveloperTools module or not.

@michalbundyra michalbundyra added the Bug Something isn't working label Mar 18, 2020
@michalbundyra
Copy link
Member

@divix1988 I've been looking on it, and I am not sure if the problem is on Laminas Developer Tools library. We are using symfony/var-dumper as it is - and by default it is using dark theme.
The problem is that whoops also using symfony/var-dumper and because of the internal implementation theme for dumper is set only once on instantiation. I guess it can be somehow fixed in integration library and the issue should be reported there.

Unless you have another idea how it can be fixed? Thanks!

@divix1988
Copy link
Author

I've raised it on the 3rd party library repo: Ppito/laminas-whoops#2
But I would keep open this ticket until we will get some response from Whoops.

@Ppito
Copy link

Ppito commented Mar 25, 2021

Hello,

I'm very sorry to reply so late, but with the actual pandemic... I totally forgot to fixed my issue.
And now it's fixed in the last release version.
So please tell me if any other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Author Updates Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants