Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaocha-cljs2 appears to hang when no clients connect #26

Open
alysbrooks opened this issue May 23, 2023 · 3 comments
Open

Kaocha-cljs2 appears to hang when no clients connect #26

alysbrooks opened this issue May 23, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@alysbrooks
Copy link
Member

alysbrooks commented May 23, 2023

If no chui-remote clients are connected, Kaocha will wait forever. You can configure a timeout, but it's not enabled by default.

This is technically correct behavior and thus, arguably, not a true hang (which implies a deadlock or other invalid state), but it isn't very friendly to people setting it up for the first time.

@plexus
Copy link
Member

plexus commented May 31, 2023

Having a default timeout would make sense, sure.

@alysbrooks alysbrooks changed the title Kaocha-cljs2 appears to hang when Kaocha-cljs2 appears to hang when no clients connect May 31, 2023
@alysbrooks
Copy link
Member Author

Another thing we could do is print a message after a shorter amount of time (or perhaps 1/2 of the timeout) that warns that no chui-client has connected yet.

@alysbrooks alysbrooks added enhancement New feature or request help wanted Extra attention is needed labels Jul 5, 2023
@alysbrooks
Copy link
Member Author

I'm biased, since I opened this issue, but I think this is a strong candidate to be one of our improvements to Kaocha-cljs2 in the near future.

@lambduhh lambduhh moved this from Triage to Candidate in Lambda Island Open Source Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Candidate
Development

No branches or pull requests

2 participants