Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in referenced paper for mixedAdditionStep implementation #243

Closed
IAvecilla opened this issue Apr 12, 2024 · 0 comments · Fixed by #254
Closed

Typo in referenced paper for mixedAdditionStep implementation #243

IAvecilla opened this issue Apr 12, 2024 · 0 comments · Fixed by #254
Assignees
@IAvecilla

Comments

@IAvecilla
Copy link
Contributor

Context: EcPairing.yul#L1327

Description: In referenced by doc comment paper there is a typo in the addition algorithm. Coefficient which is later multiplied by yp in millerLoop should not be negated as it’s originally written in https://cryptojedi.org/papers/edate-20100614.pdf Section 5.

Recommendation:

Update doc comment fro this function explaining this typo.

zkSync:

Spearbit:
@IAvecilla IAvecilla self-assigned this Apr 12, 2024
@IAvecilla IAvecilla mentioned this issue Apr 12, 2024
Merged
@IAvecilla IAvecilla linked a pull request Apr 12, 2024 that will close this issue
Fix functions doc #254
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IAvecilla IAvecilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix functions doc lambdaclass/zksync_era_precompiles
1 participant
@IAvecilla