fix(kumactl): set klog to avoid logs from k8s

Logs from klog would go to stdout which was ruining the output of commands like install-control-plane Fix kumahq#5554 Signed-off-by: Charly Molter <[email protected]>
lahabana · Jan 6, 2023 · 94a5b59 · 94a5b59
1 parent 52bbcd2
commit 94a5b59
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/kumactl/cmd/root.go b/app/kumactl/cmd/root.go
@@ -5,6 +5,7 @@ import (
 	"time"
 
 	"github.com/spf13/cobra"
+	"k8s.io/klog/v2"
 
 	"github.com/kumahq/kuma/app/kumactl/cmd/apply"
 	"github.com/kumahq/kuma/app/kumactl/cmd/completion"
@@ -44,7 +45,10 @@ func NewRootCmd(root *kumactl_cmd.RootContext) *cobra.Command {
 			if err != nil {
 				return err
 			}
-			core.SetLogger(core.NewLogger(level))
+			l := core.NewLogger(level)
+			core.SetLogger(l)
+			// Required for any k8s stuff that may log.
+			klog.SetLogger(l)
 
 			// once command line flags have been parsed,
 			// avoid printing usage instructions

diff --git a/go.mod b/go.mod
@@ -66,6 +66,7 @@ require (
 	k8s.io/apiextensions-apiserver v0.25.4
 	k8s.io/apimachinery v0.25.4
 	k8s.io/client-go v0.25.4
+	k8s.io/klog/v2 v2.80.1
 	k8s.io/kube-openapi v0.0.0-20220803162953-67bda5d908f1
 	k8s.io/utils v0.0.0-20220728103510-ee6ede2d64ed
 	sigs.k8s.io/controller-runtime v0.13.1
@@ -200,7 +201,6 @@ require (
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 	gotest.tools/v3 v3.4.0 // indirect
 	k8s.io/component-base v0.25.4 // indirect
-	k8s.io/klog/v2 v2.80.1 // indirect
 	sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 // indirect
 	sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
 )