Skip to content
This repository has been archived by the owner on May 9, 2019. It is now read-only.

Add Search UI #113

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Add Search UI #113

merged 1 commit into from
Apr 17, 2019

Conversation

ryanhanks
Copy link
Contributor

@ryanhanks ryanhanks commented Mar 23, 2019

This adds a search UI for searching items. See #73 for more details

Let me know if you have any feedback or questions. Thanks!

Basic search

Screen Shot 2019-03-30 at 9 53 44 AM

Basic search with pagination

Screen Shot 2019-03-30 at 9 58 35 AM

Screen Shot 2019-03-30 at 10 01 18 AM

Search with no keyword filter

Screen Shot 2019-03-30 at 9 50 37 AM

In-page instruction available by configuration

Screen Shot 2019-03-30 at 10 11 10 AM

@ryanhanks ryanhanks force-pushed the add_search_ui branch 4 times, most recently from eed82d6 to eafcbae Compare March 30, 2019 13:49
@ryanhanks
Copy link
Contributor Author

@ignasi35 @TimMoore @renatocaval @marcospereira this is ready for some review. Let me know if there's anyone in particular you'd like me to solicit feedback from.

Thanks!

play.application.loader = loader.WebGatewayLoader
play.filters.headers.contentSecurityPolicy = "img-src 'self' data:; default-src 'self'"

items-search.page-size = 3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty low, but I wanted the pagination features to be easily demonstrable. Let me know if you think another value is more appropriate.

@@ -2,5 +2,9 @@

lagom.circuit-breaker.default.call-timeout = 5s

online-auction.instruction.show = false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the java app defaults this to true, however, I've seen no traces of instructions in the scala implementation. Do we want to show the instructions?

@ryanhanks
Copy link
Contributor Author

ryanhanks commented Apr 6, 2019

@ignasi35 can you help me get this through? Anything in particular we need to see changed to get this across the finish line?

@ryanhanks
Copy link
Contributor Author

Would a test of some kind help?

@ryanhanks
Copy link
Contributor Author

Hi @ignasi35 @TimMoore @renatocaval @marcospereira,

I'm having a little trouble getting this through. Could someone please reply with a status update of what’s going on here in terms of this being looked at?

My apologies for being frank, and for making this statement in a public forum (it’s unclear how I might reach out to you all in a more direct manner), but the timeliness with which I’m receiving feedback here is not only frustrating, it’s also discouraging.

Lagom is a great project, and one for which I personally have a great deal of enthusiasm, and I’d like to continue to submit contributions to help bring success to the project and its community.

Please let me know if there’s another protocol I should be following in terms of how I submit contributions for review. I haven’t found any guidelines for contributing to this project, and as a result, I’ve mentioned you all out directly as it appears you’re the primary contributors to this projects. As I mentioned in my previous post, please feel free to direct me to anyone in particular that you feel could assist me in getting this (and future) work through.

I understand that you’re all quite busy with numerous other things and that this project might not at the top of your priority list, so it's understandable that this PR could have slid by without much notice. It would be nice if not only this contribution, but also further contributions could be reviewed with more transparency and visibility, and it would be great to have some clear expectations and guidelines around the PR review process and your preferred contribution process in general.

Looking forward to hearing back, getting this one through, and helping out with more contributions in the future! Thanks!

Ryan

@TimMoore
Copy link

Thanks for your contribution and for your patience, @ryanhanks. The team has been busy preparing the Lagom 1.5.0 release and with an in-person company meeting, and I'm afraid this slipped through the cracks. Someone from the team will get back to you shortly.

@ignasi35
Copy link
Contributor

Hi @ryanhanks,

as @TimMoore mentioned, we've been swamped in finishing and baking Lagom 1.5.0 and Play 2.7.1 (still not ready due to a couple of nasty bugs affecting the release process). Timing was not on our side either and the company meeting got in the way too. It's a rather intense week with some extra preparation work. To make things worse, few of us got stranded (days, not hours) at the airport on the way back due to a hard windstorm. Oh, darn, what a month. When it rains it pours.

Having said all that, this PR has been sitting unattended for very long and I fully understand your frustration and feeling of abandonment. I flew by this repo a few days back and even reviewed/merged #111, but, for some reason, I forgot about this one. That's on me.

I'm sorry you only managed to get some attention when you raised your concerns and can only say thank you for the contribution but specially to call out the issue regarding the lack of response. We want to make Lagom (and Play, and Akka, and...) successful and an active community is a key pillar to that success.

I will merge this PR now but I also wanted to take advantage of this comment to mention we are considering some changes and reorganizing of the samples, recipes and other satellite projects around Play and Lagom. See a sneak peak on the sprint plan of the current sprint. Some samples may be archived, others may need renaming or reorganizing to decrease the maintenance (we have a large amount of automation in Play samples via templatecontrol). We'll try to make sure to communicate clearly the final goal we're aiming for so each step of the process is understood as part of a clear plan. Again, this is still work in progress while we finish up the releases of Lagom 1.5.0 and Play 2.7.1.

Best,

@ignasi35 ignasi35 merged commit cad1cdd into lagom:1.4.x Apr 17, 2019
@ignasi35
Copy link
Contributor

Forward ported 1.5.x b3a87f1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants