Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] New dependency on re2 package is causing build errors in production (Github Actions) #1814

Closed
3 tasks done
gtwilliams03 opened this issue Aug 9, 2024 · 6 comments
Closed
3 tasks done
Labels

Comments

@gtwilliams03
Copy link

Describe the bug

Node.js version: 21.3.0

OS version: MacOS

Description:

Actual behavior

Builds are failing - we now have to include Python in our Dockerfile and the build is failing, likely due to a regression in the re2 1.21.3 package.

 > [12/13] RUN yarn install:
102.6 ➤ YN0000: │ re2@npm:1.21.3 STDERR gyp ERR! stack at ChildProcess.<anonymous> (/dist/.yarn/unplugged/node-gyp-npm-10.2.0-cad1109948/node_modules/node-gyp/lib/build.js:216:23)
102.6 ➤ YN0000: │ re2@npm:1.21.3 STDERR gyp ERR! System Linux 6.5.0-1025-azure
102.6 ➤ YN0000: │ re2@npm:1.21.3 STDERR gyp ERR! command "/usr/local/bin/node" "/dist/.yarn/unplugged/node-gyp-npm-10.2.0-cad1109948/node_modules/node-gyp/bin/node-gyp.js" "-j" "max" "rebuild"
102.6 ➤ YN0000: │ re2@npm:1.21.3 STDERR gyp ERR! cwd /dist/.yarn/unplugged/re2-npm-1.21.3-8175eda09b/node_modules/re2
102.6 ➤ YN0000: │ re2@npm:1.21.3 STDERR gyp ERR! node -v v21.7.3
102.6 ➤ YN0000: │ re2@npm:1.21.3 STDERR gyp ERR! node-gyp -v v10.2.0
102.6 ➤ YN0000: │ re2@npm:1.21.3 STDERR gyp ERR! not ok 
102.6 ➤ YN0009: │ re2@npm:1.21.3 couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-bd4892ab/build.log)
102.7 ➤ YN0000: └ Completed in 1m 42s
102.7 ➤ YN0000: · Failed with errors in 1m 43s

Expected behavior

Reverting to superagent 9.0.2 is workaround for now (down from 10.0.0).

Checklist

  • I have searched through GitHub issues for similar issues.
  • I have completely read through the README and documentation.
  • I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.
@gtwilliams03
Copy link
Author

We downgraded superagent to 9.0.2 from 10.0.0 in our app and the build errors did not recur and the app built and deployed successfully.

@titanism
Copy link
Collaborator

titanism commented Aug 9, 2024

We'll deprecate v10

@gtwilliams03
Copy link
Author

Thank you! I believe this issue may be relevant:

uhop/node-re2#213

@titanism
Copy link
Collaborator

We may be able to drop RE2 completely, see #1813 (comment)

@titanism
Copy link
Collaborator

superagent v10.0.1 is released (we removed re2 dependency)

https://github.com/ladjs/superagent/releases/tag/v10.0.1

@gtwilliams03
Copy link
Author

Thank you! I will reinstall superagent 10.0.1 and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants