Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle multiple segmentations in the csv output? #97

Closed
DenisSch opened this issue Apr 21, 2020 · 5 comments
Closed

How to handle multiple segmentations in the csv output? #97

DenisSch opened this issue Apr 21, 2020 · 5 comments
Labels
enhancement New feature or request quantification Issues related to the quantification module question User is asking a question segmentation Issues related to segmentation (including probability map generation)

Comments

@DenisSch
Copy link
Collaborator

We are about to enable a second segmentation module. Should we create:

  1. Subfolders in the quantification folder
  2. Change the name of the csv file according to the used segmentation

Vote:

  1. Thumbs Up
  2. Thumbs Down
@DenisSch DenisSch added enhancement New feature or request segmentation Issues related to segmentation (including probability map generation) quantification Issues related to the quantification module question User is asking a question labels Apr 21, 2020
@ArtemSokolov
Copy link
Collaborator

It's not just quantification, right? We need to subdivide prob_maps and segmentation folders too.

@DenisSch
Copy link
Collaborator Author

@ArtemSokolov I think all others will get new folders, since the amount and type of files will change. I was just hoping that we can have csv files with different names instead of same name but different folders. Too dangerous...

@ArtemSokolov
Copy link
Collaborator

Oh, I see.

@ArtemSokolov
Copy link
Collaborator

If it helps, Nextflow will be keeping track which segmentation method was run on each file, so it can correctly publish resulting files to the proper subfolder. As a consequence, the method name can be provided to quantification, if you want:

python CommandSingleCellExtraction.py ... --seg-method ilastik

@ArtemSokolov
Copy link
Collaborator

Addressed in #168 by having segmentation prepend the probability map generator name to its output folder, leading to automatic resolution of any potential name collisions in all downstream modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quantification Issues related to the quantification module question User is asking a question segmentation Issues related to segmentation (including probability map generation)
Projects
None yet
Development

No branches or pull requests

2 participants