Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One folder per device, one file for each program's class #6

Open
philipstarkey opened this issue Oct 4, 2014 · 1 comment
Open

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


In the spirit of only executing the code you need, and not putting fairly unrelated types of code together, I propose splitting labscript_devices further. Each LabscriptDeviceClassName.py in there should become LabscriptDeviceClassName/__init__.py and the BLACS tab and runviewer parsers should each be put in their own files too, named something like BLACS_tab and runviewer_parser or something. These filenames would be required in order for the classes to be found by BLACS and runviewer.

The interfaces to getting these classes would not change under this proposal, and so it would be backward compatible with the programs that use them.

It would still be:

from labscript_devices.LabscriptDeviceClassName import LabscriptDeviceClassName

for labscript, and still

labscript_devices.get_BLACS_tab and labscript_devices.get_runviewer_parser

for BLACS and runviewer

@philipstarkey
Copy link
Member Author

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


I agree. Lincoln has also agreed this sounds fine the two times I have mentioned it to him!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant