Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link the VFolder name to open the Folder Explorer in Session detail Panel #3051

Open
yomybaby opened this issue Jan 20, 2025 — with Lablup-Issue-Syncer · 0 comments · Fixed by #3038 · May be fixed by #3052
Open

Link the VFolder name to open the Folder Explorer in Session detail Panel #3051

yomybaby opened this issue Jan 20, 2025 — with Lablup-Issue-Syncer · 0 comments · Fixed by #3038 · May be fixed by #3052
Assignees

Comments

@yomybaby
Copy link
Member

yomybaby commented Jan 20, 2025

In versions of Backend.AI Core 24.12.0 and earlier, the vfolder_nodes field of compute_session_node is not provided.

There are a total of 2 Backend.AI Core responsive PRs for this issue:

  1. https://github.com/lablup/backend.ai/pull/3461
  2. https://github.com/lablup/backend.ai/pull/2987

Backend.AI WebUI responsive PRs:

  1. use vfolder_mounts field in compute_session_node and mounts field in legacy compute_session (manager < 24.12.0)
    https://github.com/lablup/backend.ai-webui/pull/3038
    1. vfolder_mounts field gives only vfolder’s id. So we need to use mounts field in legacy compute_session to get vfolder’s name. (vfolder_mounts and mounts fields are in same order)
  2. use vfolder_nodes field in compute_session_node (manager >= 24.12.0)
    https://github.com/lablup/backend.ai-webui/pull/3052
@yomybaby yomybaby changed the title Link the VFolder name to open the Folder Explorer Link the VFolder name to open the Folder Explorer in Session detail Panel Jan 20, 2025
yomybaby pushed a commit that referenced this issue Jan 24, 2025
…using vfolder_mounts (#3038)

resolves #3051 (FR-249)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

>lablup/backend.ai#3461 PR must be merged first.

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

This PR makes folder explorer available in the Session Detail Panel.

In versions prior to Backend.AI Core 24.12.0, the vfolder_nodes field is not provided. Therefore, you must use the `mounts` field of the `compute_session_node` query.

Mounts field does not provide vfolder name. So we need to use `vfolder_mounts` field in legacy `compute_session` query.  vfolder_mounts' provide the name of the vfolder in the same order as the `mounts' field in `compute_session_node'.

**Feature:**
- allow to open folder explorer in session detail panel

**How to test:**
- checkout Core branch to [lablup/backend.ai#3461](lablup/backend.ai#3461)
- open session detail panel. you can open session detail panel via using query string (?sessionDetail=<sessionID>)
- click the folder icon in session detail panel
- Verify that folder opener works for the vfolder you clicked on (name, contents, etc. match)

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment