Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: Temporarily rollback the default distributed lock impl. #592

Merged
merged 2 commits into from
May 14, 2022

Conversation

achimnol
Copy link
Member

In our internal testing, etcetra-based distributed lock seems to malfunction when spurious lock timeouts.
Until we find and fix the root cause, temporarily fallback to the prior implementation.
(This is why I've made it as a configurable option!)

@achimnol achimnol added this to the 22.03 milestone May 14, 2022
@achimnol achimnol added the bug label May 14, 2022
@achimnol achimnol self-assigned this May 14, 2022
@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #592 (ccef690) into main (91d7ca8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   48.43%   48.43%           
=======================================
  Files          53       53           
  Lines        9131     9131           
=======================================
  Hits         4423     4423           
  Misses       4708     4708           
Impacted Files Coverage Δ
src/ai/backend/manager/config.py 63.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d7ca8...ccef690. Read the comment docs.

@achimnol achimnol merged commit edb40bd into main May 14, 2022
@achimnol achimnol deleted the fix/temporary-rollback-etcd-distlock branch May 14, 2022 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant