This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: remove duplicated logic to obtain redis local time in streaming proxy requests #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
==========================================
- Coverage 48.57% 48.54% -0.04%
==========================================
Files 53 53
Lines 9126 9126
==========================================
- Hits 4433 4430 -3
- Misses 4693 4696 +3
Continue to review full report at Codecov.
|
achimnol
approved these changes
Apr 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting Redis local time in every streaming proxy request will quickly deplete the Redis connection pool. This was fixed by #526, but reintroduced by #533 by merge mistake.
This PR removes the duplicated logic to suppress the depletion of the Redis connection pool.