Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Do not MSET with empty updates in recalculate_usage() #563

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

fregataa
Copy link
Member

prevent doing mset() to redis if the given Map is empty.

@fregataa fregataa self-assigned this Mar 30, 2022
@fregataa fregataa added the bug label Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #563 (1740f6c) into main (9634db6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   49.20%   49.19%   -0.02%     
==========================================
  Files          55       55              
  Lines        9079     9081       +2     
==========================================
  Hits         4467     4467              
- Misses       4612     4614       +2     
Impacted Files Coverage Δ
src/ai/backend/manager/registry.py 18.03% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9634db6...1740f6c. Read the comment docs.

@fregataa fregataa changed the title fix: prevent empty mset to redis Do not mset() to redis if given Map is empty Mar 30, 2022
@fregataa fregataa requested a review from achimnol March 30, 2022 10:57
@achimnol achimnol changed the title Do not mset() to redis if given Map is empty Do not MSET with empty updates in recalculate_usage() Mar 30, 2022
@fregataa fregataa merged commit 3ee8539 into main Mar 30, 2022
@fregataa fregataa deleted the fix/do-not-set-empty-dict-to-redis branch March 30, 2022 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants