Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

fix: image scan failing on multi architecture image #543

Merged
merged 10 commits into from
Mar 7, 2022

Conversation

kyujin-cho
Copy link
Member

@kyujin-cho kyujin-cho commented Feb 21, 2022

This PR adds support for handling multi-architecture image manifest. This PR closes lablup/backend.ai#373.

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #543 (aa0b08b) into main (3d5fda0) will increase coverage by 0.36%.
The diff coverage is 42.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   48.82%   49.18%   +0.36%     
==========================================
  Files          54       54              
  Lines        8951     9033      +82     
==========================================
+ Hits         4370     4443      +73     
- Misses       4581     4590       +9     
Impacted Files Coverage Δ
src/ai/backend/manager/api/events.py 35.90% <0.00%> (-0.14%) ⬇️
src/ai/backend/manager/api/utils.py 58.08% <0.00%> (-0.22%) ⬇️
src/ai/backend/manager/models/domain.py 58.28% <0.00%> (ø)
src/ai/backend/manager/models/group.py 45.51% <0.00%> (ø)
src/ai/backend/manager/models/session_template.py 31.64% <0.00%> (ø)
src/ai/backend/manager/scheduler/dispatcher.py 25.40% <0.00%> (-0.14%) ⬇️
src/ai/backend/manager/registry.py 16.97% <6.25%> (-0.14%) ⬇️
src/ai/backend/manager/idle.py 30.38% <33.33%> (-0.47%) ⬇️
src/ai/backend/manager/models/agent.py 51.76% <33.33%> (-0.34%) ⬇️
src/ai/backend/manager/server.py 61.57% <37.77%> (+1.47%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03bcd52...aa0b08b. Read the comment docs.

@kyujin-cho kyujin-cho self-assigned this Feb 21, 2022
@kyujin-cho kyujin-cho added the bug label Feb 21, 2022
@kyujin-cho kyujin-cho added this to the 21.09 milestone Feb 21, 2022
@kyujin-cho kyujin-cho requested a review from achimnol February 21, 2022 15:54
@achimnol achimnol requested a review from inureyes March 2, 2022 08:52
@kyujin-cho kyujin-cho requested a review from achimnol March 6, 2022 05:13
@kyujin-cho kyujin-cho requested a review from achimnol March 7, 2022 11:03
@achimnol achimnol merged commit fd15402 into main Mar 7, 2022
@achimnol achimnol deleted the fix/multi-arch-image-crash branch March 7, 2022 12:52
achimnol pushed a commit that referenced this pull request Mar 7, 2022
* Add `strict_architecture` option to the image scanner
  to filter the image entry by the manager's architecture.

Backported-From: main (22.03)
Backported-To: 21.09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support scanning of container registries with multi-arch images
2 participants