Further apply read-only txn hints #529
Conversation
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 48.88% 48.87% -0.01%
==========================================
Files 54 54
Lines 9001 9002 +1
==========================================
Hits 4400 4400
- Misses 4601 4602 +1
Continue to review full report at Codecov.
|
| await pipe.execute() | ||
| return pipe |
There was a problem hiding this comment.
I am just curious.
is this a big change or difference?
There was a problem hiding this comment.
common.redis.execute() function accepts either a lambda to return an awaitable for Redis operation or a Redis pipeline object.
This change is to make it clearer to pass the pipeline object instead of an awaitable, though the final result is the same: executing the pipeline vs. executing an awaitable that executes the pipeline. Just a matter of style, but it reduces one extra function call.
| # TODO: Remove `type: ignore` when mypy supports type inference for walrus operator | ||
| # Check https://github.com/python/mypy/issues/7316 | ||
| # TODO: remove `NOQA` when flake8 supports Python 3.8 and walrus operator | ||
| # Check https://gitlab.com/pycqa/flake8/issues/599 |
There was a problem hiding this comment.
Though this is not related to, since this PR is changing this code block: both python/mypy#7316 and PyCQA/flake8#323 (migrated from Gitlab issue) is both resolved and released, I think it'll be good to remove all #noqa annotations.
* fix: Apply read-only txn hint when reading allowed docker registry info * fix: Apply the readonly attribute to more transactions * fix: Restore skipped lint checks due to old flake8/mypy no longer used Backported-From: main (22.03) Backported-To: 21.09
* fix: Apply read-only txn hint when reading allowed docker registry info * fix: Apply the readonly attribute to more transactions * fix: Restore skipped lint checks due to old flake8/mypy no longer used Backported-From: main (22.03) Backported-To: 21.03
No description provided.