This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: Update typing using pyright #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate from aiotools.actxmgr to contextlib.asynccontextmanager to utilize typeshed. * Correct typing of aiohttp cleanup contexts.
Codecov Report
@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 48.87% 48.83% -0.04%
==========================================
Files 54 54
Lines 8952 8965 +13
==========================================
+ Hits 4375 4378 +3
- Misses 4577 4587 +10
Continue to review full report at Codecov.
|
achimnol
added a commit
that referenced
this pull request
Dec 28, 2021
* Migrate from `aiotools.actxmgr` to `contextlib.asynccontextmanager` to utilize typeshed. * Correct typing of aiohttp cleanup contexts. * Apply type narrowing (assertions, explicitly raising exceptions on non-path branches, etc.) * Use good fallback return values to remove complicated optional typing * Fix many "possibly unbound variables" errors * Now all DB engine refs are `ExtendedAsyncSAEngine` * test: Use `MagicMock` to let type checkers correctly infer typing of mocked objects as the original class * Migrate `asyncio.ensure_future()` to `asyncio.create_task()` * Don't use "+" operator to extend `__slots__` in subclasses Backported-From: main (22.03) Backported-To: 21.09
achimnol
added a commit
that referenced
this pull request
Dec 28, 2021
* Migrate from `aiotools.actxmgr` to `contextlib.asynccontextmanager` to utilize typeshed. * Correct typing of aiohttp cleanup contexts. * Apply type narrowing (assertions, explicitly raising exceptions on non-path branches, etc.) * Use good fallback return values to remove complicated optional typing * Fix many "possibly unbound variables" errors * Now all DB engine refs are `ExtendedAsyncSAEngine` * test: Use `MagicMock` to let type checkers correctly infer typing of mocked objects as the original class * Migrate `asyncio.ensure_future()` to `asyncio.create_task()` * Don't use "+" operator to extend `__slots__` in subclasses Backported-From: main (22.03) Backported-To: 21.03
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes typing issues found by pyright, though we are not going to include pyright in CI yet.