This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
fix: Rollback polling of advisory lock in #483 #503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the busy-polling of advisory locks but preserves the
refactoring of #483 such as introduction of
connect_database()
utilityfunction.
In our customer sites, the good-old blocking advisory lock (#482) is proven to
work better, particularly with limited number of maximum database
connections.
Ultimately we should migrate distributed locking to etcd, but it requires
rewriting of the etcd3 client library and thus will be revisited in the
future.