-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Update CRUD of session template. #480
Conversation
…ormation to get, list_template.
Codecov Report
@@ Coverage Diff @@
## main #480 +/- ##
=======================================
Coverage 48.89% 48.89%
=======================================
Files 54 54
Lines 8908 8908
=======================================
Hits 4356 4356
Misses 4552 4552
Continue to review full report at Codecov.
|
fix: delete debugging codes. fix: lint errors
d0dd25f
to
e748010
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but please append trailing commas. 😉
5338711
to
9a6b4ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and it works. LGTM for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check whether checking the emptiness of query results is actually executed or not.
I think it should be rewritten to count the number of returned rows instead of performing None-check inside the for-loop against the result.
template
ordomain_name
can also be read or updated.example-session-templates.json
Related: control-panel#120, webui#1133