Any way to quickly check the history lock of one place?

[atline]

If one guy lock the place, and already unlocked it when I check issue. If possible I could use any command to find who ever locked the place?

[Bastian-Krause]

I am not sure I understand the question. Could you rephrase it?

Regarding lock history of a place, there is currently nothing except the coordinator log. See also #626.

Edit: Since #983 the coordinator logs acquire/lock and release/unlock operations.

[atline]

@Bastian-Krause

The aims is same as #626, know who at which time lock the boards, so we can find that guy. Just I'm ok to find these information from coordinator.

But the coordinator log is really big (You mean the log printed by crossbar start if I understand correctly?), so could you point to me what kinds of keyword I need to search from that huge log?

[Bastian-Krause]

Yes, I meant the log printed by crossbar start and it's pretty big. It looks like I was wrong, acquiring (locking) and releasing (unlocking) places is not really visible there. For some reason I thought we would log the same information as labgrid-client monitor shows:

Place myplace changed:
  acquired: None -> myhost/bst
[...]
Place myplace changed:
  acquired: myhost/bst -> None
[...]

... but apparently we do not log this.

So the easiest fix would probably be printing a similar message in CoordinatorComponent.acquire_place() right before it returns True at the very end:

labgrid/labgrid/remote/coordinator.py

Lines 624 to 657 in 414c88d

	@locked
	async def acquire_place(self, name, details=None):
	print(details)
	try:
	place = self.places[name]
	except KeyError:
	return False
	if place.acquired:
	return False
	if place.reservation:
	res = self.reservations[place.reservation]
	if not res.owner == self.sessions[details.caller].name:
	return False
	# FIXME use the session object instead? or something else which
	# survives disconnecting clients?
	place.acquired = self.sessions[details.caller].name
	resources = []
	for _, session in sorted(self.sessions.items()):
	if not isinstance(session, ExporterSession):
	continue
	for _, group in sorted(session.groups.items()):
	for _, resource in sorted(group.items()):
	if not place.hasmatch(resource.path):
	continue
	resources.append(resource)
	if not await self._acquire_resources(place, resources):
	# revert earlier change
	place.acquired = None
	return False
	place.touch()
	self._publish_place(place)
	self.save_later()
	self.schedule_reservations()
	return True

Would you be willing to create a PR for this?

[atline]

@Bastian-Krause Sure, here is it: #983

[Bastian-Krause]

#983 was merged.