-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop cleanup 1 #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commit needed, can you please elaborate?
I assume that when adding a new device, one measures the printhead cutter distance using a ruler. How can one measure the distance in pixels?
I think this is a physical value, thus it should be in a real distance unit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that when adding a new device, one measures the printhead cutter distance using a ruler. How can one measure the distance in pixels?
Hmm, my assumption was that we should measure the distance using a test pattern. I hadn't thought about using a ruler.
In the end we must advance the tape by some whole number of pixels, so at least in my mind pixels are the fundamental unit of length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that when adding a new device, one measures the printhead cutter distance using a ruler. How can one measure the distance in pixels?
Hmm, my assumption was that we should measure the distance using a test pattern. I hadn't thought about using a ruler.
In the end we must advance the tape by some whole number of pixels, so at least in my mind pixels are the fundamental unit of length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that makes sense now! Measuring the test pattern indeed makes it reasonable to prefer pixels over millimeters.
Some simple cleanups for the develop branch, more to come.