Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop cleanup 1 #66

Merged
merged 6 commits into from
Sep 29, 2024
Merged

Develop cleanup 1 #66

merged 6 commits into from
Sep 29, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Aug 3, 2024

Some simple cleanups for the develop branch, more to come.

@maresb maresb merged commit 5c98f8b into labelle-org:develop Sep 29, 2024
6 checks passed
@maresb maresb deleted the develop-cleanup-1 branch September 29, 2024 12:38
@maresb maresb mentioned this pull request Sep 29, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commit needed, can you please elaborate?
I assume that when adding a new device, one measures the printhead cutter distance using a ruler. How can one measure the distance in pixels?
I think this is a physical value, thus it should be in a real distance unit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that when adding a new device, one measures the printhead cutter distance using a ruler. How can one measure the distance in pixels?

Hmm, my assumption was that we should measure the distance using a test pattern. I hadn't thought about using a ruler.

In the end we must advance the tape by some whole number of pixels, so at least in my mind pixels are the fundamental unit of length.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that when adding a new device, one measures the printhead cutter distance using a ruler. How can one measure the distance in pixels?

Hmm, my assumption was that we should measure the distance using a test pattern. I hadn't thought about using a ruler.

In the end we must advance the tape by some whole number of pixels, so at least in my mind pixels are the fundamental unit of length.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that makes sense now! Measuring the test pattern indeed makes it reasonable to prefer pixels over millimeters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants