feat(business-unit): fixes for business units (#202)

- updated sdk - added better business-unit handling - added approval rule mode updating
labd · Aug 16, 2024 · 8737a6a · 8737a6a
1 parent 48e6236
commit 8737a6a
Show file tree

Hide file tree

Showing 17 changed files with 173 additions and 28 deletions.
diff --git a/.changeset/dry-walls-dance.md b/.changeset/dry-walls-dance.md
@@ -0,0 +1,5 @@
+---
+"@labdigital/commercetools-mock": minor
+---
+
+Fixed issues with business units, updated sdk to latest
diff --git a/package.json b/package.json
@@ -45,7 +45,7 @@
 	"devDependencies": {
 		"@changesets/changelog-github": "^0.5.0",
 		"@changesets/cli": "^2.27.1",
-		"@commercetools/platform-sdk": "7.3.0",
+		"@commercetools/platform-sdk": "7.11.0",
 		"@stylistic/eslint-plugin": "^1.6.2",
 		"@types/basic-auth": "^1.1.8",
 		"@types/body-parser": "^1.19.5",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/oauth/server.test.ts b/src/oauth/server.test.ts
@@ -106,6 +106,7 @@ describe("OAuth2Server", () => {
 				addresses: [],
 				authenticationMode: "password",
 				isEmailVerified: true,
+				stores: [],
 			});
 
 			const response = await supertest(app)

diff --git a/src/repositories/business-unit.ts b/src/repositories/business-unit.ts
@@ -1,4 +1,5 @@
 import {
+	BusinessUnitChangeApprovalRuleModeAction,
 	BusinessUnitChangeAssociateModeAction,
 	BusinessUnitChangeStatusAction,
 	BusinessUnitUpdateAction,
@@ -19,8 +20,8 @@ import {
 	type Company,
 	type Division,
 } from "@commercetools/platform-sdk";
-import { getBaseResourceProperties } from "../helpers";
-import { AbstractStorage } from "../storage/abstract";
+import { AbstractStorage } from "~src/storage";
+import { generateRandomString, getBaseResourceProperties } from "../helpers";
 import { Writable } from "../types";
 import {
 	AbstractResourceRepository,
@@ -43,6 +44,28 @@ export class BusinessUnitRepository extends AbstractResourceRepository<"business
 	}
 
 	create(context: RepositoryContext, draft: BusinessUnitDraft): BusinessUnit {
+		const addresses =
+			draft.addresses?.map((address) => ({
+				...address,
+				id: generateRandomString(5),
+			})) ?? [];
+
+		const defaultBillingAddressId =
+			addresses.length > 0 && draft.defaultBillingAddress !== undefined
+				? addresses[draft.defaultBillingAddress].id
+				: undefined;
+		const defaultShippingAddressId =
+			addresses.length > 0 && draft.defaultShippingAddress !== undefined
+				? addresses[draft.defaultShippingAddress].id
+				: undefined;
+
+		const shippingAddressIds = draft.shippingAddresses?.map(
+			(i) => addresses[i].id,
+		);
+		const billingAddressIds = draft.billingAddresses?.map(
+			(i) => addresses[i].id,
+		);
+
 		const resource = {
 			...getBaseResourceProperties(),
 			key: draft.key,
@@ -53,18 +76,19 @@ export class BusinessUnitRepository extends AbstractResourceRepository<"business
 			storeMode: draft.storeMode,
 			name: draft.name,
 			contactEmail: draft.contactEmail,
-			addresses: draft.addresses?.map((a) =>
-				createAddress(a, context.projectKey, this._storage),
-			),
+			addresses: addresses,
 			custom: createCustomFields(
 				draft.custom,
 				context.projectKey,
 				this._storage,
 			),
-			shippingAddressIds: draft.shippingAddresses,
-			defaultShippingAddressId: draft.defaultShippingAddress,
-			billingAddressIds: draft.billingAddresses,
+			shippingAddressIds: shippingAddressIds,
+			billingAddressIds: billingAddressIds,
+			defaultShippingAddressId: defaultShippingAddressId,
+			defaultBillingAddressId: defaultBillingAddressId,
 			associateMode: draft.associateMode,
+			approvalRuleMode: draft.approvalRuleMode,
+
 			associates: draft.associates?.map((a) =>
 				createAssociate(a, context.projectKey, this._storage),
 			),
@@ -170,6 +194,14 @@ class BusinessUnitUpdateHandler
 		}
 	}
 
+	changeApprovalRuleMode(
+		context: RepositoryContext,
+		resource: Writable<BusinessUnit>,
+		{ approvalRuleMode }: BusinessUnitChangeApprovalRuleModeAction,
+	) {
+		resource.approvalRuleMode = approvalRuleMode;
+	}
+
 	changeAssociateMode(
 		context: RepositoryContext,
 		resource: Writable<BusinessUnit>,

diff --git a/src/repositories/cart/actions.ts b/src/repositories/cart/actions.ts
@@ -30,6 +30,7 @@ import {
 	type ProductPagedQueryResponse,
 	type ProductVariant,
 } from "@commercetools/platform-sdk";
+import { DirectDiscount } from "@commercetools/platform-sdk/dist/declarations/src/generated/models/cart";
 import { v4 as uuidv4 } from "uuid";
 import { CommercetoolsError } from "~src/exceptions";
 import type { Writable } from "~src/types";
@@ -419,10 +420,13 @@ export class CartUpdateHandler
 		{ discounts }: CartSetDirectDiscountsAction,
 	) {
 		// Doesn't apply any discounts logic, just sets the directDiscounts field
-		resource.directDiscounts = discounts.map((discount) => ({
-			...discount,
-			id: uuidv4(),
-		}));
+		resource.directDiscounts = discounts.map(
+			(discount) =>
+				({
+					...discount,
+					id: uuidv4(),
+				}) as DirectDiscount,
+		);
 	}
 
 	setLineItemShippingDetails(

diff --git a/src/repositories/customer/index.ts b/src/repositories/customer/index.ts
@@ -91,6 +91,7 @@ export class CustomerRepository extends AbstractResourceRepository<"customer"> {
 				context.projectKey,
 				this._storage,
 			),
+			stores: [],
 		};
 		return this.saveNew(context, resource);
 	}

diff --git a/src/repositories/helpers.ts b/src/repositories/helpers.ts
@@ -27,7 +27,6 @@ import {
 	type StoreReference,
 	type StoreResourceIdentifier,
 	type Type,
-	type TypedMoney,
 	type _Money,
 } from "@commercetools/platform-sdk";
 import type { Request } from "express";
@@ -133,7 +132,7 @@ export const createCentPrecisionMoney = (value: _Money): CentPrecisionMoney => {
 	};
 };
 
-export const createTypedMoney = (value: _Money): TypedMoney => {
+export const createTypedMoney = (value: _Money): CentPrecisionMoney => {
 	const result = createCentPrecisionMoney(value);
 	return result;
 };

diff --git a/src/repositories/index.ts b/src/repositories/index.ts
@@ -1,3 +1,4 @@
+import { ProductTailoringRepository } from "~src/repositories/product-tailoring";
 import { AbstractStorage } from "../storage";
 import { AssociateRoleRepository } from "./associate-role";
 import { AttributeGroupRepository } from "./attribute-group";
@@ -66,6 +67,7 @@ export const createRepositories = (storage: AbstractStorage) => ({
 	"product-discount": new ProductDiscountRepository(storage),
 	"product-projection": new ProductProjectionRepository(storage),
 	"product-selection": new ProductSelectionRepository(storage),
+	"product-tailoring": new ProductTailoringRepository(storage),
 	"project": new ProjectRepository(storage),
 	"review": new ReviewRepository(storage),
 	"quote": new QuoteRepository(storage),

diff --git a/src/repositories/product-tailoring.ts b/src/repositories/product-tailoring.ts
@@ -0,0 +1,34 @@
+import type {
+	ProductTailoring,
+	ProductTailoringUpdateAction,
+} from "@commercetools/platform-sdk";
+import { AbstractStorage } from "~src/storage";
+import {
+	AbstractResourceRepository,
+	AbstractUpdateHandler,
+	RepositoryContext,
+	UpdateHandlerInterface,
+} from "./abstract";
+
+export class ProductTailoringRepository extends AbstractResourceRepository<"product-tailoring"> {
+	constructor(storage: AbstractStorage) {
+		super("product-tailoring", storage);
+		this.actions = new ProductTailoringUpdateHandler(this._storage);
+	}
+
+	create(context: RepositoryContext, draft: any): ProductTailoring {
+		throw new Error("Create method for product-tailoring not implemented.");
+	}
+}
+
+class ProductTailoringUpdateHandler
+	extends AbstractUpdateHandler
+	implements
+		Partial<
+			UpdateHandlerInterface<ProductTailoring, ProductTailoringUpdateAction>
+		>
+{
+	setSlug() {
+		throw new Error("SetSlug method for product-tailoring not implemented.");
+	}
+}