Added newline to hash and json writers #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other writers all already add a newline, except for the text writer. Since it might be significant, I decided against adding a newline there. This behaviour change is backwards compatible in the sense that the approvals don't change. Once they change, they also add the newline.
|
❤️ |
kytrinyx
added a commit
that referenced
this pull request
Feb 16, 2014
Added newline to hash and json writers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other writers all already add a newline, except for the
text writer. Since it might be significant, I decided against adding a newline there.
This behaviour change is backwards compatible in the sense that the approvals don't change. Once they change, they also add the newline.
fixes #32