fix(SideDrawer): prevent main page scrolling on sidedrawer open state #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shidoka-applications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wbarbee
approved these changes
Jan 8, 2025
brian-patrick-3
requested changes
Jan 8, 2025
There was a problem hiding this comment.
This doesn't really work because it affects things outside of the component, and requires the application to add custom CSS. I would instead recommend just using CSS overscroll-behavior: contain; on the Side Drawer body. We should do the same to Modal for consistency.
brian-patrick-3
approved these changes
Jan 8, 2025
brian-patrick-3
pushed a commit
that referenced
this pull request
Jan 8, 2025
…1.48.5...v1.48.6) (2025-01-08) ### Bug Fixes * **SideDrawer:** prevent overscroll ([#317](#317)) ([904e11d](904e11d))
|
🎉 This PR is included in version 1.48.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-next.42 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent main page scrolling on sidedrawer open state
GitHub Issue Link
#316
Checklist
analyzecommand to update Storybook docs.testlocally to address any failures.Screen Recording
Before Fix
Before_Fix.mov
After Fix
After_Fix.mov