Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formTextInput): updated caption and icon color token #313

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

kumarivijeta
Copy link
Contributor

@kumarivijeta kumarivijeta commented Jan 6, 2025

Note

kd-color--text-level-disabled currently not exists in foundation.

Summary

Text Input caption and Icon disabled state color token updated

ADO Issue

https://dev.azure.com/Kyndryl/Shidoka%20-%20Bridge%20Design%20System/_workitems/edit/2041670

Figma Link

https://www.figma.com/design/CQuDZEeLiuGiALvCWjAKlu/branch/qMpff4GuFUEcsMUkvacS3U/Applications---Component-Library?node-id=4291-236773&m=dev

Checklist

  • Used Conventional Commit messages as outlined in the contributing guide.
    • Noted breaking changes (if any).
  • Documented/updated all props, events, slots, parts, etc with JSDoc.
    • Ran the analyze command to update Storybook docs.
  • Added/updated Stories with controls to cover all variants.
  • Ran test locally to address any failures.
  • Added/updated the Figma link for the Story's Design tab.
  • Added any new component exports to the src/index.ts file

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for shidoka-applications ready!

Name Link
🔨 Latest commit 88a9767
🔍 Latest deploy log https://app.netlify.com/sites/shidoka-applications/deploys/677cbfce792958000887f1e4
😎 Deploy Preview https://deploy-preview-313--shidoka-applications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kumarivijeta kumarivijeta requested review from a team January 6, 2025 09:40
Copy link

@srpriyankashetty srpriyankashetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is resolved and verified
image
image
image

@kumarivijeta kumarivijeta merged commit af2ea44 into next Jan 7, 2025
8 of 9 checks passed
@kumarivijeta kumarivijeta deleted the BUG_2041670 branch January 7, 2025 07:07
@brian-patrick-3
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.38 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants