Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug-2044199): checkbox, checkboxGroup token updates/corrections #302

Merged
merged 11 commits into from
Dec 17, 2024

Conversation

wbarbee
Copy link
Contributor

@wbarbee wbarbee commented Dec 16, 2024

Summary (see screenshots below)

  • 1. The icon that is showing for Invalid text is in triangle shape, where as the Figma has circle
  • 2. The invalid text on disabling is not grayed out, just turns into black color
  • 3. The description is not grayed out on disabling
  • 4. Like caption the unselected checkbox color is changing when disabled.
  • 5. The parent checkbox is not showing in red, when has invalid text (issue is there in Production)

ADO Story or GitHub Issue Link

Bug 2044199

Notes

  • there were a few tokens that have been updated since the checkbox dark mode updates were merged into next that were causing these issues.
  • need to confirm hover and focused state tokens for background, border, outline when disabled = false and invalid = true:
  • unchecked
  • checked
  • parent partially checked (-)

Checklist

  • Used Conventional Commit messages as outlined in the contributing guide.
    • Noted breaking changes (if any).
  • Documented/updated all props, events, slots, parts, etc with JSDoc.
    • Ran the analyze command to update Storybook docs.
  • Added/updated Stories with controls to cover all variants.
  • Ran test locally to address any failures.
  • Added/updated the Figma link for the Story's Design tab.
  • Added any new component exports to the src/index.ts file

Testing Instructions

Provide guidance to reviewers/testers here.

Screenshots

  1. The icon that is showing for Invalid text is in triangle shape, where as the Figma has circle
Screenshot 2024-12-16 at 10 03 37 AM
  1. The invalid text on disabling is not grayed out, just turns into black color
  2. The description is not grayed out on disabling
  3. Like caption the unselected checkbox color is changing when disabled.
Screenshot 2024-12-16 at 10 11 01 AM
  1. The parent checkbox is not showing in red, when has invalid text (issue is there in Production)
Screenshot 2024-12-16 at 9 56 23 AM

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for shidoka-applications ready!

Name Link
🔨 Latest commit 369f32d
🔍 Latest deploy log https://app.netlify.com/sites/shidoka-applications/deploys/6761f07464b0210008a1a7a7
😎 Deploy Preview https://deploy-preview-302--shidoka-applications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wbarbee wbarbee requested review from a team December 16, 2024 16:25
@srpriyankashetty
Copy link

Hi @wbarbee ,
On disable the checkbox are showing as below, can you please check.!
image

@wbarbee
Copy link
Contributor Author

wbarbee commented Dec 17, 2024

Hi @wbarbee , On disable the checkbox are showing as below, can you please check.! image

this should be fixed on the deploy preview now, @srpriyankashetty. thank you

@wbarbee
Copy link
Contributor Author

wbarbee commented Dec 17, 2024

as noted above, i still need to confirm hover and focused state tokens for background, border, outline when disabled = false and invalid = true:

  • unchecked
  • checked
  • parent indeterminate

this is otherwise ready to review

@wbarbee wbarbee marked this pull request as ready for review December 17, 2024 15:02
Copy link

@srpriyankashetty srpriyankashetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the icon that is showing for Invalid text is in circle
Verified that the invalid text on disabling is grayed out
Verified that the description is grayed out on disabling
Verified that the parent checkbox is showing in red, when it has invalid text

For the issue "the unselected checkbox color is changing when disabled", have created a different bug for UX. BUG 2045697

@wbarbee wbarbee merged commit d759bd9 into next Dec 17, 2024
8 of 9 checks passed
@wbarbee wbarbee deleted the fix/bug-2044199 branch December 17, 2024 21:46
@brian-patrick-3
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants