-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bug-2044199): checkbox, checkboxGroup token updates/corrections #302
Conversation
✅ Deploy Preview for shidoka-applications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @wbarbee , |
this should be fixed on the deploy preview now, @srpriyankashetty. thank you |
as noted above, i still need to confirm hover and focused state tokens for background, border, outline when disabled = false and invalid = true:
this is otherwise ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the icon that is showing for Invalid text is in circle
Verified that the invalid text on disabling is grayed out
Verified that the description is grayed out on disabling
Verified that the parent checkbox is showing in red, when it has invalid text
For the issue "the unselected checkbox color is changing when disabled", have created a different bug for UX. BUG 2045697
🎉 This PR is included in version 2.0.0-next.30 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary (see screenshots below)
ADO Story or GitHub Issue Link
Bug 2044199
Notes
next
that were causing these issues.Checklist
analyze
command to update Storybook docs.test
locally to address any failures.Testing Instructions
Provide guidance to reviewers/testers here.
Screenshots