Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): update color token #296

Merged
merged 13 commits into from
Dec 18, 2024
Merged

feat(search): update color token #296

merged 13 commits into from
Dec 18, 2024

Conversation

kumarivijeta
Copy link
Contributor

@kumarivijeta kumarivijeta commented Dec 12, 2024 •
edited
Loading

Summary

Brief summary describing the changes here.

ADO Story

TASK 2003576

Figma Link

(https://www.figma.com/design/CQuDZEeLiuGiALvCWjAKlu/branch/qMpff4GuFUEcsMUkvacS3U/Applications---Component-Library?node-id=12050-105450&node-type=instance&m=dev)

Checklist

  • Used Conventional Commit messages as outlined in the contributing guide.
    • Noted breaking changes (if any).
  • Documented/updated all props, events, slots, parts, etc with JSDoc.
    • Ran the analyze command to update Storybook docs.
  • Added/updated Stories with controls to cover all variants.
  • Ran test locally to address any failures.
  • Added/updated the Figma link for the Story's Design tab.
  • Added any new component exports to the src/index.ts file

@kumarivijeta kumarivijeta marked this pull request as draft December 12, 2024 06:35
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for shidoka-applications ready!

Name Link
🔨 Latest commit 7897c59
🔍 Latest deploy log https://app.netlify.com/sites/shidoka-applications/deploys/6762e21db405ee0008fa2683
😎 Deploy Preview https://deploy-preview-296--shidoka-applications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kumarivijeta kumarivijeta marked this pull request as ready for review December 12, 2024 08:17
@kumarivijeta kumarivijeta requested review from a team December 12, 2024 10:01
@srpriyankashetty
Copy link

@kumarivijeta , the search icon is not grayed when disabled, can you please check.
Might not be related to color token, but in Prod its fine!
image

@kumarivijeta
Copy link
Contributor Author

kumarivijeta commented Dec 13, 2024 •
edited
Loading

@kumarivijeta , the search icon is not grayed when disabled, can you please check. Might not be related to color token, but in Prod its fine! image

@srpriyankashetty search component inherit kyn-text-input and disable state color token is not updated for the kyn-text-input component. That's why search icon is not grayed when disabled. I will check with UX designer and update accordingly as soon as I get updates on the same.
Thank you!!

srpriyankashetty
srpriyankashetty approved these changes Dec 18, 2024
View reviewed changes
Copy link

@srpriyankashetty srpriyankashetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and looks fine

@srpriyankashetty
Copy link

srpriyankashetty commented Dec 18, 2024 •
edited
Loading

Verified Disable with placeholder and looks fine in search, input text and input area

@kumarivijeta kumarivijeta merged commit adc84ed into next Dec 18, 2024
8 of 9 checks passed
@kumarivijeta kumarivijeta deleted the feat/search branch December 18, 2024 15:08
brian-patrick-3 pushed a commit that referenced this pull request Dec 18, 2024
@semantic-release-bot
chore(release): set package.json to 2.0.0-next.32 [skip ci]\n\n# [2…
cbe9f97 
….0.0-next.32](v2.0.0-next.31...v2.0.0-next.32) (2024-12-18)

### Features

* **search:** update color token ([#296](#296)) ([adc84ed](adc84ed))

### BREAKING CHANGES

* **search:** search color token updated
@brian-patrick-3
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srpriyankashetty srpriyankashetty srpriyankashetty approved these changes

@brian-patrick-3 brian-patrick-3 brian-patrick-3 approved these changes

@tulasigudibanda tulasigudibanda tulasigudibanda approved these changes

Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumarivijeta @srpriyankashetty @brian-patrick-3 @tulasigudibanda