-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(code view): dark mode token updates #287
Conversation
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
✅ Deploy Preview for shidoka-applications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…cations into next
…cations into next
…cations into next
…cations into next
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending copy button design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified and looks fine in both Dark and light mode,
Please let me know if we are good with Copy button
🎉 This PR is included in version 2.0.0-next.43 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Coalesce dark and light syntax themes into a united theme that relies on new tokens with the following rules:
color-scheme
attribute setting for system-based dark or light modedarkTheme
property that the dev can set to override the theme when desiredADO Story or GitHub Issue Link
Code View ADO Task
Figma Link
Code View Updated Figma
To Do
darkTheme
override hierarchyTesting Instructions
--kd-color-code-view-background | light-dark(#fafafc, #222527)
this will be updated as soon as available
Checklist
analyze
command to update Storybook docs.test
locally to address any failures.Screenshots