You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We used to rely on finalizers when generating a shared FluentBit configuration for multiple LogPipelines. The old approach looked as follows:
When a new LogPipeline is added, a FluentBit section snippet is added to the shared config, and a finalizer is added to the LogPipeline.
When the LogPipeline is removed, the deletion is blocked because there is a finalizer.
LogPipeline reconciler updates the shared configuration by removing the corresponding snippet and "free" the LogPipeline by removing the finalizer
Since we deprecated this approach and are now generating a config for all LogPipelines together in every reconciliation, we don't need finalizers anymore. Furthermore, we don't use finalizers for Trace and Metric Pipelines, so we should remove them for consistency.
Acceptance Criteria
Remove the code adding FLUENT_BIT_SECTIONS_CONFIG_MAP and FLUENT_BIT_FILES finalizers in LogPipelines
Make sure non of the existing LogPipeline have those finalizers
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.
kyma-bot
added
lifecycle/rotten
Denotes an issue or PR that has aged beyond stale and will be auto-closed.
and removed
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
labels
Nov 19, 2024
Description
We used to rely on finalizers when generating a shared FluentBit configuration for multiple LogPipelines. The old approach looked as follows:
Since we deprecated this approach and are now generating a config for all LogPipelines together in every reconciliation, we don't need finalizers anymore. Furthermore, we don't use finalizers for Trace and Metric Pipelines, so we should remove them for consistency.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: