Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of finalizers in LogPipeline reconciler #1440

Open
skhalash opened this issue Sep 12, 2024 · 2 comments
Open

Usage of finalizers in LogPipeline reconciler #1440

skhalash opened this issue Sep 12, 2024 · 2 comments
Labels
area/logs LogPipeline

Comments

@skhalash
Copy link
Collaborator

Description

We used to rely on finalizers when generating a shared FluentBit configuration for multiple LogPipelines. The old approach looked as follows:

  • When a new LogPipeline is added, a FluentBit section snippet is added to the shared config, and a finalizer is added to the LogPipeline.
  • When the LogPipeline is removed, the deletion is blocked because there is a finalizer.
  • LogPipeline reconciler updates the shared configuration by removing the corresponding snippet and "free" the LogPipeline by removing the finalizer

Since we deprecated this approach and are now generating a config for all LogPipelines together in every reconciliation, we don't need finalizers anymore. Furthermore, we don't use finalizers for Trace and Metric Pipelines, so we should remove them for consistency.

Acceptance Criteria

  • Remove the code adding FLUENT_BIT_SECTIONS_CONFIG_MAP and FLUENT_BIT_FILES finalizers in LogPipelines
  • Make sure non of the existing LogPipeline have those finalizers
@skhalash skhalash added the area/logs LogPipeline label Sep 12, 2024
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2024
Copy link

This issue has been automatically closed due to the lack of recent activity.
/lifecycle rotten

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
@kyma-bot kyma-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 19, 2024
@a-thaler a-thaler removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 19, 2024
@a-thaler a-thaler reopened this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline
Projects
None yet
Development

No branches or pull requests

3 participants