Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric input for kyma status as annotation #1182

Closed
a-thaler opened this issue Jun 17, 2024 · 1 comment
Closed

New metric input for kyma status as annotation #1182

a-thaler opened this issue Jun 17, 2024 · 1 comment
Assignees
Labels
area/metrics MetricPipeline kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Jun 17, 2024

Description
As part of #728 have an annotation for MetricPipelines ready which will activate the new receiver for collecting kyma module status.

The annotation might be named like:

telemetry.kyma-project.io/kymastats: true

Criterias

  • Have an annotation in place which is disabled by default and can be activated by setting the value to "true"
  • If enabled, the new kymastats receiver gets enabled wrapped by the leader-election receiver and will start collecting metrics for all modules
  • The receiver is either running in the agent or the gateway, decision pending on that
  • The instrumentationScope is defined as for other inputs
  • If one MetricPipeline is activating the new input while a second does not, the second pipeline should not export the data
  • Have e2e tests in place

Reasons

Attachments

Release Notes


@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/metrics MetricPipeline labels Jun 17, 2024
@a-thaler a-thaler changed the title New metric input for kyma status New metric input for kyma status as annotation Jul 23, 2024
@a-thaler
Copy link
Collaborator Author

a-thaler commented Jul 23, 2024

A config which works for me:

        singleton_receiver_creator:
          auth_type: serviceAccount
          leader_election:
            lease_name: telemetry-metric-agent-kymastats
            lease_namespace: kyma-system
          receiver:
            kymastats:
              auth_type: serviceAccount
              collection_interval: 30s
              module_groups:
              - operator.kyma-project.io
              - connectivityproxy.sap.com
              - operator.sme.sap.com

New RBAC settings working for me:

Role:

- apiGroups:
  - coordination.k8s.io
  resources:
  - leases
  verbs:
  - get
  - list
  - watch
  - create
  - patch
  - update

ClusterRole:

- apiGroups:
  - operator.kyma-project.io
  - connectivityproxy.sap.com
  - operator.sme.sap.com
  resources:
  - '*'
  verbs:
  - list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics MetricPipeline kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants