Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ResourceName #87

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

nesmabadr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Remove resourceName from ModuleConfig

Related issue(s)
Resolves #86

@nesmabadr nesmabadr requested review from a team as code owners October 29, 2024 07:55
@nesmabadr nesmabadr force-pushed the remove_resourceName branch 5 times, most recently from 7207d59 to 04706c9 Compare October 29, 2024 08:54
# Conflicts:
#	internal/service/contentprovider/moduleconfig.go
#	internal/service/moduleconfig/generator/moduleconfig_generator_test.go
#	internal/service/moduleconfig/reader/moduleconfig_reader_test.go
#	internal/service/templategenerator/templategenerator.go
@nesmabadr nesmabadr force-pushed the remove_resourceName branch from 04706c9 to 21b8169 Compare October 29, 2024 08:58
@kyma-bot kyma-bot removed the lgtm label Oct 29, 2024
@kyma-bot kyma-bot added the lgtm label Oct 29, 2024
@jeremyharisch jeremyharisch merged commit 46c159d into kyma-project:main Oct 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Catalog] Remove ResourceName from ModuleConfig file
4 participants