Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Align GH-Actions internal Repo with KLM Repo #2104

Merged
merged 14 commits into from
Dec 13, 2024

Conversation

nesmabadr
Copy link
Contributor

@nesmabadr nesmabadr commented Dec 10, 2024

Description

Changes proposed in this pull request:

  • Remove cmctl installation
  • Align modulectl, istioctl and k3d installation

Related issue(s)
Resolves #1653

@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2024
@nesmabadr nesmabadr requested a review from a team as a code owner December 10, 2024 10:01
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 10, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2024
@nesmabadr nesmabadr force-pushed the align_gh_actions branch 6 times, most recently from 3ff09d3 to 4f1431d Compare December 10, 2024 12:15
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2024
@nesmabadr nesmabadr force-pushed the align_gh_actions branch 2 times, most recently from d7c0d11 to c268d52 Compare December 10, 2024 12:27
@nesmabadr nesmabadr force-pushed the align_gh_actions branch 5 times, most recently from 8f304a3 to 9f910c8 Compare December 10, 2024 13:06
@nesmabadr nesmabadr enabled auto-merge (squash) December 12, 2024 15:06
@nesmabadr nesmabadr merged commit afbd614 into kyma-project:main Dec 13, 2024
65 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2024
c-pius pushed a commit to c-pius/lifecycle-manager that referenced this pull request Dec 13, 2024
* test cert manager deployment without cmctl

* Delete install-cmctl action

* Align istioctl

* Align k3d

* Align install-modulectl

* install-kustomize

* install-kustomize

* remove install-kustomize

* minor fixes
medmes pushed a commit to medmes/lifecycle-manager that referenced this pull request Dec 13, 2024
* test cert manager deployment without cmctl

* Delete install-cmctl action

* Align istioctl

* Align k3d

* Align install-modulectl

* install-kustomize

* install-kustomize

* remove install-kustomize

* minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align GH-Actions internal Repo with KLM Repo
3 participants