Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Catalog does not retry failed provisioning #7288

Closed
mszostok opened this issue Feb 20, 2020 · 2 comments
Closed

Service Catalog does not retry failed provisioning #7288

mszostok opened this issue Feb 20, 2020 · 2 comments
Assignees
@jasiu001 @ksputo
Labels
area/service-management Issues or PRs related to service management

Comments

@mszostok
Copy link
Contributor

Description

This is the code line where the provisioning of the ServiceInstance fails:

kyma/components/application-broker/internal/broker/provision.go

Line 240 in 2bed6bc

instanceState = internal.InstanceStateFailed

How to reproduce:
Before creating the ServiceInstance: <- cluster is in this state atm

kubectl scale --replicas=0 -n kyma-system deployment event-sources-controller-manager
kubectl delete channels.messaging.knative.dev -n kyma-integration nachtmaar

After creating the ServiceInstance and the first provision request fails:

kubectl scale --replicas=1 -n kyma-system deployment event-sources-controller-manager
kubectl get channels.messaging.knative.dev -n kyma-integration nachtmaar # check channel has been recreated

As discussed in the call: I see this message in service catalog Not processing event because status showed there is no work to do
@mszostok mszostok added the area/service-management Issues or PRs related to service management label Feb 20, 2020
@mszostok mszostok added this to the Sprint_Gopher_37 milestone Feb 20, 2020
@mszostok mszostok assigned mszostok and ksputo and unassigned mszostok Feb 20, 2020
@nachtmaar
Copy link
Contributor

Related to this issue: #7193

@jasiu001 jasiu001 self-assigned this Feb 28, 2020
@PK85 PK85 modified the milestones: Sprint_Gopher_37, Sprint_Gopher_38 Mar 2, 2020
@k15r k15r changed the title Service Catalog does not retries failed provisioning Service Catalog does not retry failed provisioning Mar 5, 2020
@nachtmaar nachtmaar mentioned this issue Mar 17, 2020
Closed
@ksputo
Copy link
Contributor

ksputo commented Mar 18, 2020

To sum up the investigation:

  • service catalog's behaviour is like this by design, not a bug - see service-catalog/PR-2520
  • Platform (service catalog) performs Orphan Mitigation (which is basically cleaning up all the resources from the failed provisioning process) when it gets status: failed in response from polling for last operation.
  • It should be broker who performs retries after failed provisioning, not the platform, which was also mentioned here. In this particular case the retries could be added when asking for kubernetes custom resources.
  • The problem with current OSB API contract is that we can't really tell if the provisioning error was permanent or temporary - there is a agreement for covering those issues in OSB API v3 (and probably then changes in service catalog will be introduced)

Some context about the history of service catalog behaviour:

Closing for now.

@ksputo ksputo closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasiu001 jasiu001

@ksputo ksputo

Labels
area/service-management Issues or PRs related to service management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nachtmaar @PK85 @jasiu001 @mszostok @ksputo