Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the way how finalizers are removed in controller-manager #2835

Closed
mszostok opened this issue Feb 22, 2019 · 1 comment
Closed

Unify the way how finalizers are removed in controller-manager #2835

mszostok opened this issue Feb 22, 2019 · 1 comment
Assignees
@mszostok
Labels
area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mszostok
Copy link
Contributor

Description

api-server has bug in PreperForUpdate functions for statuses.

Implemented logic does not allow modification under .Spec but all another field can be changed e.g. metadata entry. Thanks to that removing finalizers worked in controllers.
After removing api-server and using the status sub-resource on CRD this action is not allowed. Only status entry can be changed.

Proposed Solution:

  1. Remove the finalizers by updating the resource. See POC implementation.

AC:

  • removing finalizer works with CRD status sub-resources
  • same approach is used in all controllers
@mszostok mszostok added the area/service-management Issues or PRs related to service management label Feb 22, 2019
@mszostok mszostok mentioned this issue Feb 22, 2019
Closed
@derberg derberg added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 22, 2019
@derberg derberg modified the milestones: Backlog_Gopher, Sprint_Gopher_12 Feb 22, 2019
@PK85 PK85 modified the milestones: Sprint_Gopher_12, Sprint_Gopher_13 Mar 4, 2019
@mszostok mszostok self-assigned this Mar 8, 2019
@mszostok mszostok mentioned this issue Mar 21, 2019
Merged
3 tasks
@piotrmiskiewicz piotrmiskiewicz self-assigned this Mar 22, 2019
@mszostok
Copy link
Contributor Author

mszostok commented Mar 25, 2019 •
edited
Loading

After merging PR, service catalog removes finalizers when given kind was clean-up successfully.

Consumed SP: ~4SP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mszostok mszostok

Labels
area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aszecowka @derberg @PK85 @piotrmiskiewicz @mszostok