Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the CRDs for Service Catalog resources #2798

Closed
adamwalach opened this issue Feb 19, 2019 · 1 comment
Closed

Define the CRDs for Service Catalog resources #2798

adamwalach opened this issue Feb 19, 2019 · 1 comment
Assignees
Labels
area/service-management Issues or PRs related to service management

Comments

@adamwalach
Copy link
Contributor

adamwalach commented Feb 19, 2019

Description
We should define the full working CRDs for Service Catalog.

NOTE:
Controller-manager is using the status-subresource on all ServiceCatalog resources.
Issue can be resolved by adding

subresources:
  status: {}

to do CRD definition.
This feature is in beta. Current design status can be found in this issue.

In POC we already did that and it worked without any problem.

Assumptions:

  • k8s at least in version 1.11

AC

  • Service Catalog CRDs defined
  • status subresource available on all CRDs
  • CRDs has static validation via OpenAPI v3 schema
  • we know how we will install those CRDs (e.g. direct def in chart or in controller manager or sth else)
  • custom columns out of scope, will be implemented in this issue: Replace TableConvertor with AdditionalPrinterColumns in SC #2790
@adamwalach adamwalach added the area/service-management Issues or PRs related to service management label Feb 19, 2019
@mszostok mszostok changed the title Add Status Subresource to CRDs - SC Define the CRDs for Service Catalog resources Feb 22, 2019
@mszostok mszostok added this to the Sprint_Gopher_12 milestone Feb 22, 2019
@mszostok
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-management Issues or PRs related to service management
Projects
None yet
Development

No branches or pull requests

4 participants