Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit maximum length of environment keys generated by a logpipeline #15939

Closed
a-thaler opened this issue Oct 28, 2022 · 1 comment
Closed

limit maximum length of environment keys generated by a logpipeline #15939

a-thaler opened this issue Oct 28, 2022 · 1 comment
Labels
area/logging Issues or PRs related to the logging module (deprecated)

Comments

@a-thaler
Copy link
Contributor

a-thaler commented Oct 28, 2022

Description
It turned out that with fluentbit 2.0 the maximum length of an environment key is limited. A key like ABC_APP_TEST_CLS_FLUENT_BIT_SECRET_FLUENTD_HTTP_HOST gets replaced proper when used in a a variable placeholder, but a key like ABC_APPLICATION_LOG_TEST_CLS_FLUENT_BIT_SECRET_FLUENTD_HTTP_HOST simply gets not resolved.

Even if the issue gets created and fixed, there might be a limit always and it should be assured that generated keys cannot grow indefinitely.

So please limit the max length of the generated keys.

Criterias

  • environment variable keys which can be used in fluentbit placeholders have a maximum length
  • the maximum is compatible with fluentbit 2
  • upgrade to new logic will not break existing setups
@a-thaler
Copy link
Contributor Author

The issue got fixed upstream and is already available with newest patch version 2.0.5. I verified it and it works as before. As the chance of running into further limits is very rare, I will close the issue as the priority gets very low.

@a-thaler a-thaler closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Issues or PRs related to the logging module (deprecated)
Projects
None yet
Development

No branches or pull requests

1 participant