Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to v1alpha2.Function fails when editing function resources from Busola #15009

Closed
kwiatekus opened this issue Aug 4, 2022 · 1 comment
Labels
area/serverless Issues or PRs related to serverless kind/bug Categorizes issue or PR as related to a bug.

Comments

@kwiatekus
Copy link
Contributor

kwiatekus commented Aug 4, 2022

Description

There seem to be a problem with conversion to v1alpha2.Function when operating from busola

  • by default min replicas are equal to max replicas - so the function starts with 5 pods
  • if I change resources in Kyma UI I see error

Screenshot 2022-08-04 at 12 04 48

Expected result

  • By default, Function's min replicas should be 1.
  • Clients supporting v1alpha1.Function should be abble to submit changes w/o errors during grace period

Actual result

  • By default, Function's min replicas is equal to max replicas.
ERROR	Converting webhook	failed to convert	{"request": "1c3593f8-47ad-46c7-ad97-142744d01e6d", "error": "while decoding conversion request object: v1alpha1.Function.Spec: v1alpha1.FunctionSpec.BuildResources: v1.ResourceRequirements.Limits: unmarshalerDecoder: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$', error found in #10 byte of ...|:{\"cpu\":\"\",\"memory\":|..., bigger context ...|753\"},\"spec\":{\"buildResources\":{\"limits\":{\"cpu\":\"\",\"memory\":\"\"},\"requests\":{\"cpu\":\"\",\"memory\":\"\"}},\"|...", "errorVerbose": "v1alpha1.Function.Spec: v1alpha1.FunctionSpec.BuildResources: v1.ResourceRequirements.Limits: unmarshalerDecoder: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$', error found in #10 byte of ...|:{\"cpu\":\"\",\"memory\":|..., bigger context ...|753\"},\"spec\":{\"buildResources\":{\"limits\":{\"cpu\":\"\",\"memory\":\"\"},\"requests\":{\"cpu\":\"\",\"memory\":\"\"}},\"|...\nwhile decoding conversion request object

Steps to reproduce

Create a function in Kyma UI.
Observe that is starts with 5 replicas from the start.
Try to change the resources.

Related Issues

#14593
#15005
#15012

@kwiatekus kwiatekus added kind/bug Categorizes issue or PR as related to a bug. area/serverless Issues or PRs related to serverless labels Aug 4, 2022
@kwiatekus
Copy link
Contributor Author

The above error was because of missing webhooks.
Already fixed by #15049.

Now there are two problems when editing functions in busola tracked separatelly:
kyma-project/busola#1751
kyma-project/busola#1750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serverless Issues or PRs related to serverless kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant