-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function jobs shouldn't request resources by default #14440
Comments
The code which check minimum values requested: kyma/components/function-controller/pkg/apis/serverless/v1alpha1/function_validation.go Lines 24 to 32 in cc7cbc4
Also look here in charts, for example: kyma/resources/serverless/charts/webhook/values.yaml Lines 101 to 102 in 30c0da1
|
We should
|
Thanks |
Description
In current implementation by default we enforce build profile.
Expected result
By default the build profiles are not applied.
Actual result
Having those values set as default, that:
let's consider following situation:
User creates 3 function on node with 2000cpu available:
By default we shouldn't apply any build profiles or at least not enforce minimum request for build jobs.
I would consider to also remove the default profile for functions if the user didn't specify.
Steps to reproduce
Troubleshooting
Settings for minimum requests: https://github.com/kyma-project/kyma/blob/main/components/function-controller/pkg/apis/serverless/v1alpha1/function_validation.go#L28=
The text was updated successfully, but these errors were encountered: