Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich Runtime CRs with commercial service plan data #1521

Closed
a-thaler opened this issue Dec 3, 2024 · 2 comments
Closed

Enrich Runtime CRs with commercial service plan data #1521

a-thaler opened this issue Dec 3, 2024 · 2 comments

Comments

@a-thaler
Copy link

a-thaler commented Dec 3, 2024

Description
In order to migrate KMC to leverage runtime CRs only (kyma-project/kyma-metrics-collector#89) and get rid of the KEB to EDP call (kyma-project/kyma-metrics-collector#90), KMC need to have access to the commercial service plan data of a runtime/subacount.

Goal: Enrich every runtime CR with the service plan information of the underlying subscription

Every subscription belongs to a service plan like "standard", "test", or "tdd".

@PK85
Copy link

PK85 commented Dec 9, 2024

@a-thaler I think this mapping from KEB could be moved to KMC and then we do not add more labels to the RuntimeCR, see:

func (s *EDPRegistrationStep) selectServicePlan(planID string) string {

@a-thaler
Copy link
Author

a-thaler commented Dec 9, 2024

I agree, the mapping should be moved to KMC indeed, will close the ticket

@a-thaler a-thaler closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants