From 677f8289f12bd9be86e2c9ce94c47773fce7e7cc Mon Sep 17 00:00:00 2001 From: Wojciech Nawa Date: Mon, 22 Jan 2024 08:25:31 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Grzegorz Karaluch --- README.md | 23 +++++++++++------------ main.go | 1 - 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index d39b533..db36e8b 100644 --- a/README.md +++ b/README.md @@ -81,18 +81,17 @@ make deploy ### Configuration Envs -| Name | Default | Description | -|------------------------------------|------------------------------------------------------------------------------|------------------------------------------------------------------------------------| -| `APP_ADDRESS` | `127.0.0.1:3000` | Adress on which the app will be exposed | -| `APP_APIENDPOINT` | `/graphql` | Endpoint for GraphQL requests | -| `APP_PLAYGROUNDAPIENDPOINT` | `/graphql` | This option is not used | -| `APP_SKIPDIRECTORCERTVERIFICATION` | `false` | Skip cert verification in Compass Director GraphQL calls | -| `APP_DIRECTOR_URL` | `https://compass-gateway-auth-oauth.mps.dev.kyma.cloud.sap/director/graphql` | URL of the Compass Director GraphQL endpoint | -| `APP_DIRECTOR_OAUTH_PATH` | `./dev/director.yaml` | File with OAuth data for Compass Director | -| `APP_ENABLED_REGISTRATION` | `false` | Enable registering runtimes with Compass | -| `APP_DRYRUN` | `false` | Disable registering and configuring, instead log what operations would be executed | - -> **TIP:** `CompassManagerMappings` created with dry run will be labeled `kyma-project.io/cm-dry-run: Yes` +| Name | Default | Description | +|------------------------------------|------------------------------------------------------------------------------|-------------------------------------------------------------------------------------| +| `APP_ADDRESS` | `127.0.0.1:3000` | Address on which the app is exposed | +| `APP_APIENDPOINT` | `/graphql` | Endpoint for GraphQL requests | +| `APP_SKIPDIRECTORCERTVERIFICATION` | `false` | Skips cert verification in the Compass Director GraphQL calls | +| `APP_DIRECTOR_URL` | `https://compass-gateway-auth-oauth.mps.dev.kyma.cloud.sap/director/graphql` | URL of the Compass Director GraphQL endpoint | +| `APP_DIRECTOR_OAUTH_PATH` | `./dev/director.yaml` | File with OAuth data for Compass Director | +| `APP_ENABLED_REGISTRATION` | `false` | Enable registering runtimes with Compass | +| `APP_DRYRUN` | `false` | Disable registering and configuring; instead log which operations would be executed | + +> **TIP:** `CompassManagerMappings` created with dry run are labeled `kyma-project.io/cm-dry-run: Yes` > Explain how to use the project. You can create multiple subsections (H3). Include the instructions or provide links to the related documentation. diff --git a/main.go b/main.go index cae5ab1..7b1a448 100644 --- a/main.go +++ b/main.go @@ -38,7 +38,6 @@ var ( type config struct { Address string `envconfig:"default=127.0.0.1:3000"` APIEndpoint string `envconfig:"default=/graphql"` - PlaygroundAPIEndpoint string `envconfig:"default=/graphql"` SkipDirectorCertVerification bool `envconfig:"default=false"` DirectorURL string `envconfig:"APP_DIRECTOR_URL,default=https://compass-gateway-auth-oauth.mps.dev.kyma.cloud.sap/director/graphql"` DirectorOAuthPath string `envconfig:"APP_DIRECTOR_OAUTH_PATH,default=./dev/director.yaml"`