Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore PRs not Merged to Main #671

Merged

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Apr 22, 2024

Description

Release action loads PR to validate kind labels with versioning scheme. The scripts used in that process take into account all PRs merged to any branch in repository - not only the main branch. See https://github.com/kyma-project/btp-manager/actions/runs/8753032654. Changelog should not be affected by the same issue, it is generated from a log of a local git clone.

Results from the failed release:

Run python3 scripts/python/release_label_validator.py
One of these labels is required on PR: ['kind/feature', 'kind/enhancement', 'kind/bug']

These PRs have exactly one required label:
PR: https://github.com/kyma-project/btp-manager/pull/656
PR: https://github.com/kyma-project/btp-manager/pull/669
PR: https://github.com/kyma-project/btp-manager/pull/650
PR: https://github.com/kyma-project/btp-manager/pull/661
PR: https://github.com/kyma-project/btp-manager/pull/660
PR: https://github.com/kyma-project/btp-manager/pull/655
PR: https://github.com/kyma-project/btp-manager/pull/654
PR: https://github.com/kyma-project/btp-manager/pull/647

These PRs don't have exactly one required label:
PR: https://github.com/kyma-project/btp-manager/pull/662
PR: https://github.com/kyma-project/btp-manager/pull/648
Error: Process completed with exit code 1.

Results from local invocation of labels validation script:

(venv) ➜  btp-manager git:(bugfixes/validate-release-by-main-only) ✗ python3 ./scripts/python/release_label_validator.py
One of these labels is required on PR: ['kind/feature', 'kind/enhancement', 'kind/bug']

These PRs have exactly one required label:
PR: https://github.com/kyma-project/btp-manager/pull/670
PR: https://github.com/kyma-project/btp-manager/pull/656
PR: https://github.com/kyma-project/btp-manager/pull/669
PR: https://github.com/kyma-project/btp-manager/pull/650
PR: https://github.com/kyma-project/btp-manager/pull/661
PR: https://github.com/kyma-project/btp-manager/pull/660
PR: https://github.com/kyma-project/btp-manager/pull/647

All PRs have exactly one required label

Version name is correct

Changes proposed in this pull request:

  • Filter loaded pr to only those that got merged to main.

Related issue(s)

@ralikio ralikio requested a review from a team as a code owner April 22, 2024 08:31
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2024
@ralikio ralikio added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 22, 2024
@ralikio ralikio changed the title Ignore PRs not Merged to Dev Ignore PRs not Merged to Main Apr 22, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 22, 2024
@kyma-project kyma-project deleted a comment from kyma-bot Apr 22, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 22, 2024
@ralikio ralikio removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 22, 2024
@kyma-bot kyma-bot merged commit ed76776 into kyma-project:main Apr 22, 2024
18 checks passed
ukff pushed a commit to ukff/btp-manager that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants