-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ratelimit validation #1508
Ratelimit validation #1508
Conversation
0645f53
to
6f7e919
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should organise code differently.
reconcile: controllers/gateway/ratelimit
api: apis/gateway/v1alpha1/ratelimit
I think we should set naming scheme for the CRDs like so:
- for APIs -
apis/{group}/{version}/{name}
- for controllers -
controllers/{group}/{name}
The code can be easily in the same group but in different packages. Please adjust the code and possibly revert the changes you did to move the code into the gateway package.
Restructured slightly different: |
Co-authored-by: Natalia Sitko <[email protected]>
Co-authored-by: Natalia Sitko <[email protected]>
Description
Changes proposed in this pull request:
Pre-Merge Checklist
Related issues