Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnvoyFilter builder #1368

Closed
5 of 10 tasks
Tracked by #1365
strekm opened this issue Oct 10, 2024 · 0 comments
Closed
5 of 10 tasks
Tracked by #1365

EnvoyFilter builder #1368

strekm opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.

Comments

@strekm
Copy link
Contributor

strekm commented Oct 10, 2024

Description

Implement abstraction for building EnvoyFilter to support rate limiting. EnvoyFilter is complex CR for wide range of tasks in Istio. Implementation should be focused on Rate Limiting story local scenario. The builder later on will be used in reconciliation of RateLimiting CR. Have in mind that minimal implementation is limited but it will be extended so implementation should be flexible.

AC:

  • EnvoyFilter builder introduced

TODOs:

  • Create EnvoyFilter Builder
  • Create local RateLimit builder for EnvoyFilter
  • Implement unit tests

Reasons

DoD:

  • Provide unit and integration tests.
  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
  • If you changed the resource limits, explain why it was needed.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
  • Add release notes.

Attachments
https://github.com/kyma-project/istio/blob/main/docs/contributor/adr/0008-rate-limit.md
part of: #1365

@strekm strekm added kind/feature Categorizes issue or PR as related to a new feature. area/api-gateway Issues or PRs related to api-gateway labels Oct 10, 2024
@strekm strekm mentioned this issue Oct 10, 2024
16 tasks
@Ressetkk Ressetkk self-assigned this Oct 14, 2024
@Ressetkk Ressetkk removed their assignment Oct 17, 2024
@barchw barchw self-assigned this Oct 18, 2024
@Ressetkk Ressetkk assigned Ressetkk and unassigned barchw Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants