Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDBX corruption when saving with YubiKey removed #2

Closed
kylemanna opened this issue Aug 24, 2014 · 2 comments
Closed

KDBX corruption when saving with YubiKey removed #2

kylemanna opened this issue Aug 24, 2014 · 2 comments
Assignees

Comments

@kylemanna
Copy link
Owner

As mentioned by @fabian-z

But perhaps the most serious flaw I found is a database corruption, which is triggered when opening a challenge-response secured database, removing the yubikey and then trying to save the database. The save was not delayed as before with no error and apparently led to database corruption (was reproducable for me)! Could you please adress the corruption problem?

keepassx#52 (comment)

Steps to reproduce:

  1. Create kdbx with password + yk
  2. Add entry / test data and save
  3. Remove yk
  4. Save kdbx file (will silently fail and encrypt file with garbage)

Possibly other bugs.

Expected behavior:

  • Complain to the user that the Yubikey must be re-inserted to save the file or changes will be lost.
@kylemanna kylemanna self-assigned this Aug 24, 2014
@fabian-z
Copy link

fabian-z commented Sep 9, 2014

Confirmed fixed as of b7fd29b 😃

@kylemanna
Copy link
Owner Author

This was a big oversight on my part originally. Thanks for catching, reporting, and testing! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants