Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error on Ruby < 2.6 #419

Closed
benjaminwood opened this issue Mar 1, 2022 · 3 comments
Closed

Syntax error on Ruby < 2.6 #419

benjaminwood opened this issue Mar 1, 2022 · 3 comments

Comments

@benjaminwood
Copy link

The code in question (match[1..]) uses Ruby 2.6's infinite range syntax.

I believe we intend to support Ruby 2.4, so this should be changed. We should also run our tests against all supported Ruby versions to ensure this cannot happen again.

SyntaxError: /app/vendor/bundle/ruby/2.4.0/gems/zoom_rb-1.1.1/lib/zoom/actions.rb:6: syntax error, unexpected ']'00:05
\w+/).map { |match| match[1..].to_sym }
@benjaminwood
Copy link
Author

If it turns out we do not intend to support Ruby < 2.6, let's at least specify a minimum ruby version so folks don't run into this unexpectedly.

@dil-bparihar
Copy link

can we have a solution for it @kyleboe because i am also trying to use the latest version of it with ruby 2.5 and getting the same error or please tell me the possible solution i could do it from my side. Thanks

@kyleboe
Copy link
Owner

kyleboe commented Dec 9, 2022

Thanks for your fix for this @dil-bparihar! #447 has been merged and 1.1.7 is released!

@kyleboe kyleboe closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants