Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo modernization #424

Open
kylebarron opened this issue Apr 7, 2022 · 1 comment
Open

Repo modernization #424

kylebarron opened this issue Apr 7, 2022 · 1 comment

Comments

@kylebarron
Copy link
Owner

I don't have a ton of free time at the moment, but here are some (opinionated) suggestions for making the repo easier to maintain in the future. Take these as suggestions to be discussed

@mcaceresb
Copy link
Collaborator

@kylebarron I don't have particularly strong feelings on these. Of course I have peeves about formatting but I'm self-aware in that I know they're subjective (and inconsistent Un_n).

  • pyupgrade seems like a good idea.

  • black looks good; I would assume moving from YAPF won't be hard.

  • isort seems fine—I reckon consistency matters more than the actual choices in this case.

  • click seems nice (I think I have a memory of argparse being annoying to work around when doing the magics but not 100%).

  • I have mixed feelings on static typing for python. In general I'm quite happy for languages to have static types (or optional static types, like with Julia). In Python's case the interpreter ignores it, AFAIK, which makes me sad ):

    So if there's a situation where typing matters the check has to be added by the programmer. While mypy sounds like a good idea nonetheless, I guess it's hard for me to be excited about it when a) I haven't seen it in action and, more importantly, b) migrating to static typing seems by far to be the most labor-intensive bullet point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants