Pass in style attribute to style attachment #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kybishop
requested changes
May 17, 2018
There was a problem hiding this comment.
Thanks @jrjohnson! This is looking great, just a few minor comments.
addon/components/attach-popover.js
Outdated
| @@ -39,6 +40,7 @@ export default Component.extend({ | |||
| } | |||
| }), | |||
| class: DEFAULTS.class, | |||
| style: DEFAULTS.style, | |||
There was a problem hiding this comment.
Bikeshed: Let's keep these alphabetized by moving this to the bottom of this property list.
There was a problem hiding this comment.
No problem, done.
addon/components/attach-popover.js
Outdated
| _style: computed('style', '_transitionDuration', function () { | ||
| const style = this.get('style'); | ||
| const transitionDuration = this.get('_transitionDuration'); | ||
| assert( |
There was a problem hiding this comment.
Doesn't ember normally warn when we pass a style that wasn't marked with htmlSafe? If so, I think we should follow suit over asserting.
There was a problem hiding this comment.
Good call. I thought it was an error, but it is, in fact, just a warning. Fixed
addon/defaults.js
Outdated
| @@ -2,6 +2,7 @@ export default { | |||
| animation: 'fill', | |||
| arrow: false, | |||
| class: null, | |||
| style: null, | |||
There was a problem hiding this comment.
Let's alphabetize this, too.
jrjohnson
force-pushed
the
135-dynamic-styles
branch
from
d222779
to
e403ca9
Compare
Allows passing in a safe string as a style which will be applied to the tooltip or attachment element.
jrjohnson
force-pushed
the
135-dynamic-styles
branch
from
e403ca9
to
f78f427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing in a safe string as a style which will be applied to the
tooltip or attachment element.
Fixes #135