Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #128

Merged
merged 3 commits into from
Apr 23, 2018
Merged

Improve README #128

merged 3 commits into from
Apr 23, 2018

Conversation

mostafa-sakhiri
Copy link
Contributor

As I did not understand why arrows didn't work the first time, I think it could be better if this was specified in the documentation.

@kybishop kybishop merged commit b9ef250 into tylerturdenpants:master Apr 23, 2018
@kybishop
Copy link
Collaborator

Thanks @mostafa-sakhiri! We have a (IMO) nice looking popover in the dummy app that uses a custom background color, and has its arrow styled to match. I made a "Styles" section and linked to the CSS, as well as mentioned the bit about arrows.

@mostafa-sakhiri
Copy link
Contributor Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants