Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hideOn and showOn broken when undefined #76

Closed
RobbieTheWagner opened this issue Oct 17, 2017 · 2 comments
Closed

hideOn and showOn broken when undefined #76

RobbieTheWagner opened this issue Oct 17, 2017 · 2 comments

Comments

@RobbieTheWagner
Copy link
Collaborator

If you pass an undefined hideOn or showOn, we should probably grab the defaults instead of using undefined. Right now it blows up on trying to do .split.
@kybishop
Copy link
Collaborator

Agreed on grabbing the defaults for undefined. I'm pondering what we should do for null though...

I think we should assume the user is purposely asking for no hideOn or showOn actions.

@RobbieTheWagner
Copy link
Collaborator Author

@kybishop yeah undefined I would use defaults and null I would disable it. Alternatively, we could throw errors for undefined and require people to define something.

@kybishop kybishop mentioned this issue Nov 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kybishop @RobbieTheWagner